Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update monitor image to newer python #3247

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

infotroph
Copy link
Member

Description

Updates the base image for monitor to use Python 3.12 and bumps all required packages to their current latest stable releases.

I don't know the monitor system well, so pinging @robkooper for review. I confirmed that the image builds locally, that the Docker stack comes back up afterward, and that pecan.localhost/monitor still loads and displays running models. If this PR needs testing beyond that, please advise.

Motivation and Context

The requests version bump proposed in #3173 no longer builds because of version incompatibilities, and it also seems the Python 3.5 base image is out of support. I figured jumping forward to current versions of everything would be faster than playing whackamole with individual version changes.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infotroph infotroph added this pull request to the merge queue Jan 2, 2024
Merged via the queue into PecanProject:develop with commit 03cbff8 Jan 2, 2024
7 of 12 checks passed
@infotroph infotroph deleted the monitor-update branch February 19, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants